-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollbar #871
base: master
Are you sure you want to change the base?
Add rollbar #871
Conversation
Adds error logging in Rollbar
The idea being that any error messages emanating from R inside the app will get reported, right? I've glanced over the minimal documentation in the On a different note while searching for that I came across this, may also log errors but not sure: https://github.com/dreamRs/shinylogs Looks fine but a little more info would be useful. Is it the ease with which we can see logs on the rollbar website, which allows authentication via GitHub? I recall you set up a similar system already but cannot recall - did it have 'dog' in the name? |
I agree. I tried to get |
To clarify, what is the next step on this that you're suggesting @nikolai-b ? Package age alone doesn't need to be a blocker but wanted to explore options before reviewing this. |
If you want to explore options we can leave it sitting for a week or two. No rush. Otherwise it's good to go. Even if we do deploy it we can always do something better, I'm not set on rollbar. What I do want is to be alerted if the code errors.
|
I think there is no chance of issues with this and generally think moving things forward is good. Given low risk and minimal change to code base will review with 👍 now. |
Does rollbar need to be added in the |
I did it before as I wanted the installed packages to raise an error that will be caught (assuming rollbar works) but we could probably rejig it if you prefer. |
Was wondering how to ensure an error message is generated. But not sure that library(rollbar)
#> Error in library(rollbar): there is no package called 'rollbar' Created on 2021-03-29 by the reprex package (v1.0.0) Is a particularly useful error message if we're looking to test the package! |
You'll need to install the package and use the correct Renviron with our |
This is good to go I think @nikolai-b. |
Adds error logging in Rollbar. After adding this to another project I realised it wasn't much work in R. The other logging I tried to add never seemed to work as the R server logs weren't in quite the correct format. I've added the Renviron and rollbar package to all the servers in preparation.